feat: add optional CBOR representation to GET_ACCOUNT_INFO #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccicci
force-pushed
the
feat/GET_ACCOUNT_INFO_cbor
branch
from
5c26d93 to
b536bf6
Compare
iccicci
force-pushed
the
feat/GET_TRANSACTION_cbor
branch
from
09b3697 to
36edc11
Compare
iccicci
force-pushed
the
feat/GET_ACCOUNT_INFO_cbor
branch
from
b536bf6 to
a12326e
Compare
iccicci
force-pushed
the
feat/GET_TRANSACTION_cbor
branch
from
36edc11 to
7eee599
Compare
iccicci
force-pushed
the
feat/GET_ACCOUNT_INFO_cbor
branch
from
a12326e to
d82aab9
Compare
iccicci
force-pushed
the
feat/GET_TRANSACTION_cbor
branch
from
7eee599 to
36b7266
Compare
iccicci
force-pushed
the
feat/GET_ACCOUNT_INFO_cbor
branch
from
d82aab9 to
3714972
Compare
iccicci
force-pushed
the
feat/GET_TRANSACTION_cbor
branch
from
36b7266 to
393db04
Compare
iccicci
force-pushed
the
feat/GET_ACCOUNT_INFO_cbor
branch
from
3714972 to
ae7b387
Compare
iccicci
force-pushed
the
feat/GET_TRANSACTION_cbor
branch
from
393db04 to
99ba285
Compare
iccicci
force-pushed
the
feat/GET_ACCOUNT_INFO_cbor
branch
from
ae7b387 to
f4e2a97
Compare
iccicci
force-pushed
the
feat/GET_TRANSACTION_cbor
branch
from
99ba285 to
671636e
Compare
iccicci
force-pushed
the
feat/GET_ACCOUNT_INFO_cbor
branch
from
f4e2a97 to
c07d859
Compare
iccicci
force-pushed
the
feat/GET_TRANSACTION_cbor
branch
from
7d3b2b9 to
5f3ab98
Compare
iccicci
force-pushed
the
feat/GET_ACCOUNT_INFO_cbor
branch
from
c07d859 to
7ea6882
Compare
iccicci
force-pushed
the
feat/GET_ACCOUNT_INFO_cbor
branch
from
7ea6882 to
86ebd8e
Compare
slowbackspace
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
lgtm! please add unit test for get-account-info to https://github.com/blockfrost/blockfrost-websocket-link/blob/ba7a3176bcb76639abf0c5103f91d04a5f2ec65e/test/unit/tests/methods/get-account-info.test.ts to cover new param.
Check out comments in the file on how to automatically record needed requests using nock
slowbackspace
force-pushed
the
feat/GET_ACCOUNT_INFO_cbor
branch
from
38f10c0 to
4ebfd1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #253