Skip to content

Commit

Permalink
update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
khufkens committed Aug 28, 2024
1 parent 1d3b4f9 commit 74be7cd
Showing 1 changed file with 10 additions and 14 deletions.
24 changes: 10 additions & 14 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,30 +3,26 @@
Dear CRAN team,

This is a major version increment due to the migration of the ECMWF APIs.

Hereby, the package will drop the support of the old API in favour of the
new one, confusingly still called "beta". I've added additional support for
the Copernicus Emergency Management System (CEMS) data store.
new one, confusingly still called "beta".

The workflows remain largely the same with data requests
backwards compatible with the previous versions. Some components such as
legacy support for the WebAPI are removed. This service should have been
removed a long time ago but is still there. However, use cases are few. I now
refer to the older v1 package for WebAPI support.
legacy support for the WebAPI and CDS Toolbox are removed. I've added additional support for
the Copernicus Emergency Management System (CEMS) data store. I now
refer to the older v1 (github) package for WebAPI support.

For optimization, the batch processing script now also
checks for duplicate filenames and reports this as such, limiting
checks for duplicate filenames, limiting
accidental data overwrites. Consolidation of the APIs authentication
leads to a more compact code base (thankfully), but creates some breaking
leads to a more compact code base, but creates some breaking
changes due to the omission of a 'user' argument (with a consistent default).

These breaking changes are well documented, and migration should be as simple
Breaking changes are well documented, and migration should be as simple
as providing the new Personal Access Token and removing the user argument in
API query functions.

Consolidation of the API as the advantage that mixed queries of various
services are now allowed. Mixing for example querying climate data from CDS,
with atmospheric data from ADS in one batch.
API query functions. Consolidation of the API has the advantage that mixed
queries of various data services are now allowed. Mixing for example querying
climate data from CDS, with atmospheric data from ADS in one batch.

Kind regards,
Koen Hufkens
Expand Down

0 comments on commit 74be7cd

Please sign in to comment.