-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch time out #127
patch time out #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #127 +/- ##
===========================================
+ Coverage 11.23% 53.24% +42.00%
===========================================
Files 20 20
Lines 979 986 +7
===========================================
+ Hits 110 525 +415
+ Misses 869 461 -408 ☔ View full report in Codecov by Sentry. |
Fix for #125
Queries returned 500 errors on downloads recently. I assume rate limiting is in place due to data migration. The polling
retry
frequency at 5s was potentially too high. I reduced this to a default of 30s and made the variable dynamic. I also included a dynamic http code in the first query (ignored in the update status section though).