tests: Do not write to current working directory #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedora installs tests to validate the installed modules later. The
intallation location for the tests is read only. Git-Repository tests
already utilize File::Temp to use a proper temporary directory. The
only exception was t/05-try_git.t:
Error in tempdir() using t/XXXXXXXXXX: Could not create directory t/FHkns_IVOr: Permission denied at t/05-try_git.t line 71.
# Looks like your test exited with 13 just after 20.
t/05-try_git.t ............. Dubious, test returned 13 (wstat 3328, 0xd00)
Failed 16/36 subtests
This patch fixes the test to prefer a platform-provided location for temporary
files (e.g. /tmp) over the current working directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora installs tests to validate the installed modules later. The intallation location for the tests is read only. Git-Repository tests already utilize File::Temp to use a proper temporary directory. The only exception was t/05-try_git.t:
This patch fixes the test to prefer a platform-provided location for temporary files (e.g. /tmp) over the current working directory.