Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url 파싱의 숫자 변환 추가 #194

Merged
merged 2 commits into from
Dec 15, 2020
Merged

url 파싱의 숫자 변환 추가 #194

merged 2 commits into from
Dec 15, 2020

Conversation

Eunsol0410
Copy link
Collaborator

@Eunsol0410 Eunsol0410 commented Dec 15, 2020 •
edited
Loading

  • validateStyle에서 굵기, 채도, 명도의 타입이 숫자인지 체크해서, 이슈가 있어 수정하였음
  • PR 💥에러 리스트💥 #161

@Eunsol0410
[fix] urlParsing 숫자로 전환 추가
b350795 
- 기존 굵기, 채도, 명도의 값이 string이라서 validate에서 문제를 일으켰음
@Eunsol0410
[fix] url 파싱 에러 픽스
c2cea5b
@Eunsol0410 Eunsol0410 added this to the 5주차 milestone Dec 15, 2020
@Eunsol0410 Eunsol0410 self-assigned this Dec 15, 2020
@Eunsol0410 Eunsol0410 requested review from limlimlimlimlimlim and a user December 15, 2020 01:58
@Eunsol0410 Eunsol0410 merged commit 1064391 into boostcamp-2020:feature/history Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitgitWi gitgitWi gitgitWi approved these changes

@yyjjjj yyjjjj yyjjjj approved these changes

@limlimlimlimlimlim limlimlimlimlimlim Awaiting requested review from limlimlimlimlimlim

Assignees

@Eunsol0410 Eunsol0410

Labels
bug fix
Projects
None yet
Milestone
5주차
Development

Successfully merging this pull request may close these issues.
3 participants
@Eunsol0410 @yyjjjj @gitgitWi