Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

회원가입 api 구현 #75

Merged
merged 11 commits into from
Nov 16, 2023
Merged

회원가입 api 구현 #75

merged 11 commits into from
Nov 16, 2023

Conversation

Muungi
Copy link
Collaborator

@Muungi Muungi commented Nov 16, 2023

Resolves: #20, resolves: #25, resolves: #55

진행내용

  • : 회원가입 요청 시 데이터 유효성 검사 후 회원가입 진행
  • : email 중복 확인
  • : 회원가입 성공시 DB에 저장
  • : 회원가입 요청에 대한 응답 반환

    • 회원가입 성공
      회원가입성공응답

    • 이메일 중복
      중복이메일응답

    • 유효하지 않은 입력값
      유효x응답

@Muungi Muungi added feature 새로운 기능 backend 백엔드 관련 labels Nov 16, 2023
@Muungi Muungi requested a review from sickbirdd November 16, 2023 05:21
@Muungi Muungi self-assigned this Nov 16, 2023
github-actions[bot]
github-actions bot reviewed Nov 16, 2023
View reviewed changes
backend/src/app.module.ts Outdated Show resolved Hide resolved
backend/src/app.module.ts Outdated Show resolved Hide resolved
backend/src/configs/typeorm.config.ts Outdated Show resolved Hide resolved
backend/src/exceptions/exception.fillter.ts Outdated Show resolved Hide resolved
backend/src/exceptions/validation.exception.ts Outdated Show resolved Hide resolved
backend/src/exceptions/validation.user.pipe.ts Outdated Show resolved Hide resolved
backend/src/exceptions/validation.user.pipe.ts Outdated Show resolved Hide resolved
backend/src/exceptions/validation.user.pipe.ts Outdated Show resolved Hide resolved
backend/src/user/user.controller.ts Outdated Show resolved Hide resolved
backend/src/user/user.controller.ts Outdated Show resolved Hide resolved
@Muungi
Copy link
Collaborator Author

Muungi commented Nov 16, 2023

Delete ␍ prettier/prettier 에러 해결하는 과정에서 eslint 설정을 잘못 적용했더니 로컬에서 검사가 안되고 있었네요...
덕분에 reviewdog의 성능(?)을 확인할 수 있었습니다ㅠㅠ
다음부터는 검사 잘 해서 올리도록 하겠습니다😁

sickbirdd
sickbirdd reviewed Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@sickbirdd sickbirdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전반적으로 깔끔하게 코드 작성해주셔서 읽기가 편했어요! Good Good

backend/src/app.module.ts Outdated Show resolved Hide resolved
backend/src/configs/typeorm.config.ts Outdated Show resolved Hide resolved
backend/src/exceptions/exception.fillter.ts Outdated Show resolved Hide resolved
backend/src/user/user.repository.ts Outdated Show resolved Hide resolved
@sickbirdd sickbirdd self-requested a review November 16, 2023 06:03
@sickbirdd sickbirdd added this to the 2주차 milestone Nov 16, 2023
This was linked to issues Nov 16, 2023
[회원가입 화면] 회원가입 정보를 검증하고 DB에 저장한다. #20
Closed
[회원가입 화면] 회원가입 결과를 반환한다. #25
Closed
[회원가입 화면] 아이디 중복 여부를 응답한다 #55
Closed
@sickbirdd sickbirdd self-requested a review November 16, 2023 12:07
sickbirdd
sickbirdd requested changes Nov 16, 2023
View reviewed changes
backend/src/exceptions/exception.fillter.ts Outdated Show resolved Hide resolved
backend/src/exceptions/exception.fillter.ts Outdated Show resolved Hide resolved
@sickbirdd
Copy link
Collaborator

고생하셨습니다!

@sickbirdd sickbirdd merged commit c296f7e into dev/be Nov 16, 2023
1 check passed
This was referenced Nov 16, 2023
Closed
Closed
Closed
Closed
@Muungi Muungi deleted the feat/be/signup branch December 14, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@sickbirdd sickbirdd sickbirdd approved these changes

Assignees

@Muungi Muungi

Labels
backend 백엔드 관련 feature 새로운 기능
Projects
None yet
Milestone
2주차
2 participants
@Muungi @sickbirdd