Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/re-enter-room : 방 재참가 고려 #154

Merged
merged 9 commits into from
Dec 6, 2023
Merged

feat/re-enter-room : 방 재참가 고려 #154

merged 9 commits into from
Dec 6, 2023

Conversation

sjn0910
Copy link
Collaborator

@sjn0910 sjn0910 commented Dec 5, 2023

Checklist

  • Code Review: 작성한 코드를 다시 한 번 꼼꼼이 확인했나요?
  • Testing: 앱이 잘 구동되는지 개발한 기능이 문제 없이 작동하는지 확인했나요?
  • Remove: print나 주석 등 필요없는 코드를 삭제했나요?

Description

  • 방 재참가의 경우도 고려하여 createOrRestoreRoomUser 메서드를 생성했고 방 생성 및 방 참가 service 로직에서 사용가능합니다.
  • 이외에 사용되지 않는 몇가지 코드를 제거했습니다.

@sjn0910 sjn0910 requested a review from vimkim December 5, 2023 16:54
@sjn0910 sjn0910 self-assigned this Dec 5, 2023
vimkim
vimkim approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@vimkim vimkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 잘봤습니다!

server/src/auth/auth.strategy.ts Show resolved Hide resolved
server/src/roomUser/room.user.service.ts Show resolved Hide resolved
@sjn0910 sjn0910 merged commit 99265cc into develop Dec 6, 2023
2 checks passed
@sjn0910 sjn0910 deleted the feat/re-enter-room branch December 7, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vimkim vimkim vimkim approved these changes

Assignees

@sjn0910 sjn0910

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjn0910 @vimkim