Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/random select #160

Merged
merged 13 commits into from
Dec 6, 2023
Merged

Feat/random select #160

merged 13 commits into from
Dec 6, 2023

Conversation

glowisn
Copy link
Collaborator

@glowisn glowisn commented Dec 6, 2023

Checklist

  • Code Review: 작성한 코드를 다시 한 번 꼼꼼이 확인했나요?
  • Testing: 앱이 잘 구동되는지 개발한 기능이 문제 없이 작동하는지 확인했나요?
  • Remove: print나 주석 등 필요없는 코드를 삭제했나요?

Description

close #152

  • 드롭다운이 object를 받음
  • 랜덤 문제 불러오기, 문제 등록
  • 문제 4개까지만 등록되게 함
  • 상위 30개 태그 하드코딩
  • 다중 선택 드롭다운 UI 직관적으로 변경
  • 랜덤 선택에서 태그와 난이도 선택해야 요청 가능

Changes Made

client/public/tags.ts : 태그들
client/src/apis/randomProblems.ts : 랜덤요청 API
client/src/components/RoomSettingModal/RandomProblem.tsx : 랜덤문제 요청
client/src/components/RoomSettingModal/RoomSettingModal.tsx : 문제 상태 RandomProblem Component로 내리기
client/src/components/RoomSettingModal/SearchResults.tsx: 자동완성 검색 컴포넌트

client/src/components/RoomSettingModal/SelectProblem.tsx : 문제 선택 컴포넌트

client/src/types/Tag.ts : 태그 타입

Extra Comments

Demo

에러 처리
image

선택시 UI 직관적으로 변경
image

@glowisn glowisn self-assigned this Dec 6, 2023
@glowisn glowisn requested review from Lukaid-dev and kiuuon December 6, 2023 07:28
@glowisn glowisn marked this pull request as ready for review December 6, 2023 07:28
@Lukaid-dev Lukaid-dev self-requested a review December 6, 2023 08:42
Copy link
Collaborator

@Lukaid-dev Lukaid-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@kiuuon kiuuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 수고하셨습니다 😃

@glowisn glowisn merged commit 8ef3167 into develop Dec 6, 2023
1 check passed
@glowisn glowisn deleted the feat/randomSelect branch December 6, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat : 랜덤 선택 API
3 participants