Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/landing page #165

Merged
merged 11 commits into from
Dec 7, 2023
Merged

Feat/landing page #165

merged 11 commits into from
Dec 7, 2023

Conversation

Lukaid-dev
Copy link
Collaborator

@Lukaid-dev Lukaid-dev commented Dec 6, 2023

Checklist

  • Code Review: 작성한 코드를 다시 한 번 꼼꼼이 확인했나요?
  • Testing: 앱이 잘 구동되는지 개발한 기능이 문제 없이 작동하는지 확인했나요?
  • Remove: print나 주석 등 필요없는 코드를 삭제했나요?
  • Rebase: (필요시) rebase를 완료했나요?
  • Conflict Resolution: 충돌을 해결하는 과정을 거쳤나요?

Description

intro page는 우선 미완인 상태입니다. 시연때 미완인 상태라는 것을 고지해야 할 것 같아요

close #164

Changes Made

client/src/App.tsx

  • ThemeComponent를 삭제하고 이를 Theme Setting로 대체

client/src/components/ThemeSettingModal.tsx

  • Theme을 세팅하는 모달

client/src/components/VideoPlayer.tsx

  • intro page에서 쓰이는 비디오 플레이어 컴포넌트인데, 음성이 있는 비디오의 경우 자동 재생이 브라우저 정책에 따라 금지됨

client/src/pages/Intro.tsx

  • 인트로 페이지. 앞으로 계속 수정해야함

client/src/pages/Lobby.tsx

  • 로비에 theme modal관련 프로퍼티 생성

client/src/pages/NotFound.tsx

  • 간단히 만든 404페이지

client/src/routes.tsx

  • intro route를 추가

client/tailwind.config.js

  • 글자색을 투명하게하는 transparent속성 적용할 수 있도록 추가함
  • 이를 bg-clip-text 등의 옵션과 함께 사용해서 글자의 색을 다이나믹하게 지정 가능함

Extra Comments

Demo

소리가 안나오네요...

2023-12-07.11.06.48.mov

image

@Lukaid-dev Lukaid-dev requested review from glowisn and kiuuon December 6, 2023 14:59
@Lukaid-dev Lukaid-dev self-assigned this Dec 6, 2023
@Lukaid-dev Lukaid-dev marked this pull request as ready for review December 7, 2023 14:08
Copy link
Collaborator

@kiuuon kiuuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intro 페이지 예쁘네요 😃 수고하셨습니다1

@Lukaid-dev Lukaid-dev removed the request for review from glowisn December 7, 2023 14:42
@Lukaid-dev Lukaid-dev merged commit a049ea3 into develop Dec 7, 2023
1 check passed
@Lukaid-dev Lukaid-dev deleted the feat/landingPage branch December 7, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Landing Page
2 participants