[BE/#417] RefreshToken Redis 저장 #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koomin1227
approved these changes
Dec 9, 2023
| const refreshToken = this.generateRefreshToken(user); | ||
| return { access_token: accessToken, refresh_token: refreshToken }; | ||
|
|
||
| if ((await this.cacheManager.get(user.user_hash)) === refreshtoken) { |
There was a problem hiding this comment.
redis에 저장된 refesh token만 사용할 수 있게 되었네요
BE/src/login/login.service.ts
Outdated
| await this.cacheManager.set( | ||
| user.user_hash, | ||
| refreshToken, | ||
| 60 * 60 * 24 * 2, |
| const userPk = await this.checkAuth(id, userId); | ||
| const decodedToken: any = jwt.decode(accessToken); | ||
| if (decodedToken && decodedToken.exp) { | ||
| await this.fcmHandler.removeRegistrationToken(decodedToken.userId); |
There was a problem hiding this comment.
유저 탈퇴할 때 registration token 삭제는 까먹었는데 넣어주셔서 감사합니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
체크리스트
고민한 내용
스크린샷