Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Boost.Filesystem usage, add BOOST_NO_CXX17_AUTO_NONTYPE_TEMPLATE_PARAMS #492

Merged

Conversation

Lastique
Copy link
Member

This PR:

  • Updates tools/generate.cpp to avoid using Boost.Filesystem APIs that were deprecated and now removed.
  • Adds a new BOOST_NO_CXX17_AUTO_NONTYPE_TEMPLATE_PARAMS macro that indicates whether the compiler does not support C++17 auto non-type template parameters.

The previously deprecated Boost.Filesystem APIs are now removed. This
commit updates test generator to use the up-to-date replacement APIs.
The macro indicates whether the compiler does not support C++17
auto non-type template parameters.
@Lastique
Copy link
Member Author

Ping @jzmaddock. Note that at least the first commit needs to be merged, as currently tools/generate.cpp fails to compile.

@jzmaddock
Copy link
Collaborator

Failure are due to b2 dropping GCC-4 support, merging...

@jzmaddock jzmaddock merged commit 601598f into boostorg:develop Jan 26, 2024
29 of 30 checks passed
@Lastique Lastique deleted the feature/cxx17_auto_nontype_template_params branch January 26, 2024 16:56
@Lastique
Copy link
Member Author

Thanks. Drone failure is because of a b2 issue, which was reportedly fixed.

@Lastique
Copy link
Member Author

Lastique commented Feb 2, 2024

Please, also merge to master as there is downstream code that uses this macro that I would like to merge as well.

@jzmaddock
Copy link
Collaborator

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants