Upgrades to match GTSAM 4.3 - #440
Merged
Merged
Conversation
Member
|
One CI failed so I reran failed |
Member
|
CI still fails :-( |
Contributor
Author
|
The CI is failing because the GTSAM python wrapper is exceeding RAM. I did a benchmark yesterday and the slam module alone takes up 12 GB, so with concurrent jobs the total compile RAM goes up to 29 GB. Seems like a lot of templating was added to these modules without proper care for compile time metrics, so CI is killing the job. |
Member
|
Yes, and I already fixed it. |
Contributor
Author
|
Not quite, since this same issue affects Docker container building and other things where 32 GB of RAM isn't available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made various updates so that we can compile GTD with GTSAM 4.3 with the deprecations turned off.