fix(sqlite): change to better-sqlite3 to fix packaging with node 16 #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmasse
commented
Mar 10, 2022
|
knex-schema-inspector doesn't work with better-sqlite3, even though supporting it would require 1 line fix knex/knex-schema-inspector#95 |
samuelmasse
commented
Mar 10, 2022
Comment on lines
+165
to
166
| .orderBy('sentOn', 'desc', this.db.getIsLite() ? 'first' : 'last') | ||
| .orderBy('createdOn', 'desc') |
There was a problem hiding this comment.
No idea why this is needed but the previous behavior doesn't work after the knex bump
|
It looks like unique constraints are not being enforced when running the tests on the ci for whatever reason... |
samuelmasse
commented
Mar 10, 2022
Comment on lines
+1
to
6
| test('TODO: reimplement this', () => {}) | ||
|
|
||
| /* | ||
| import { Inspector } from './utils/database' | ||
| import { startMessagingServer } from './utils/server' | ||
|
|
There was a problem hiding this comment.
I'm commenting out this test for now because knex-schema-inspector doesn't work with better-sqlite3. Since we're not adding migrations at the moment it's not critical that this is run. We'll add it back pretty soon. Might require implementing our own schema inspector or patching knex-schema-inspect
|
Note: make more foreign key tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes DEV-2424