-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to save stitched image as h5 or zarr #14
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
- Coverage 96.89% 95.20% -1.69%
==========================================
Files 6 6
Lines 419 626 +207
==========================================
+ Hits 406 596 +190
- Misses 13 30 +17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Igor this looks / works great! It ran nicely on the big_test_data
and was easy to use. The code was clear to read, I'm not so familiar with zarr / h5 so could not pass an expert eye over everything but looks good to me. I've got some questions / suggestions on the code and below is some feedback from using the GUI:
- Once 'Fuse' is run, does it make sense to auto-load it into napari? Or maybe a popup like 'fused file saved to XXXX'. I wasn't sure what had happened once 'fused' was pressed. However, later learnt to keep an eye on the terminal when using napari. But maybe new users are not familiar with this and using it as a pure GUI.
- When you click the 'Browse' button, even if you don't select anything it overwrites anything you have in the lineedit. Sometimes I miss-clicked on it and it removed what I had in the lineedit when I didn't want it to. Maybe it is worth checking if the file browser dialog returns "" or whatever it's null return is, and in this case do not update the lineedit.
- I ran this on the very tiny dataset and got an error, might be worth looking into (but maybe just a small dataset issue)
- If I tried to save the fuse output to a folder that already exists, I get a relative uninformative error
path '0' contains an array
.
Description
What is this PR
Why is this PR needed?
There is no way to save the fused image in the preview as one 3D image.
What does this PR do?
Adds functionality to save the fused image as either a BigDataViewer compatible h5 file or as an OME-Zarr.
How has this PR been tested?
Tests have been added to cover the new functionality.
NOTE:
To test the functionality locally you must install Fiji and also add BigStitcher to the update sites. This can be done using the GUI see here or via the command line after installing Fiji.
Replace
ImageJ-linux64
with the path to the local ImageJ executable.Three different datasets are available for testing:
Is this a breaking change?
No.
Does this PR require an update to the documentation?
No.
Checklist: