Skip to content

Commit

Permalink
Don't call FcFini()
Browse files Browse the repository at this point in the history
Fontconfig has a bug in FcFini() where it calls assert when it probably
shouldn't. This looks to be fixed in
https://gitlab.freedesktop.org/fontconfig/fontconfig/-/commit/6f6b39780215714386606ca1c5457a7106639ff4,
which is in libfontconfig >=2.13.93.

Removing this seems to be safe, it will cause valgrind to show mem
leaks, but it doesn't look to be a problem in practice.
  • Loading branch information
brndnmtthws committed Feb 26, 2024
1 parent 316e48f commit 8e8adaf
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/display-x11.cc
Original file line number Diff line number Diff line change
Expand Up @@ -701,9 +701,6 @@ void display_output_x11::cleanup() {
XDestroyRegion(x11_stuff.region);
x11_stuff.region = nullptr;
}
#ifdef BUILD_XFT
FcFini();
#endif /* BUILD_XFT */
}

void display_output_x11::set_foreground_color(Colour c) {
Expand Down

0 comments on commit 8e8adaf

Please sign in to comment.