More X11 cleanup #1250
Merged
More X11 cleanup #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conkyweb canceled.
|
mmuman
force-pushed
the
x11-cleanup
branch
2 times, most recently
from
3ee01bc to
5e7ac5d
Compare
mmuman
changed the title
|
We can probably resolve the rest later. |
|
Is there anything holding this up from being merged? I'd like to move forward with #1310 as soon as possible. |
|
@mmuman is this ready to merge? If so, please merge away. |
|
I'm going to assume this is ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed those to get something displayed with SDL. There are still some more around but I wasn't sure how to deal with them.
Maybe the NULL test is not always required, but I haven't tried removing them yet. Maybe we should introduce some helper function instead to lower the verbosity?