Don't call FcFini() #1755
Merged
Don't call FcFini() #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fontconfig has a bug in FcFini() where it calls assert when it probably shouldn't. This looks to be fixed in https://gitlab.freedesktop.org/fontconfig/fontconfig/-/commit/6f6b39780215714386606ca1c5457a7106639ff4, which is in libfontconfig >=2.13.93. Removing this seems to be safe, it will cause valgrind to show mem leaks, but it doesn't look to be a problem in practice.
✅ Deploy Preview for conkyweb canceled.
|
brndnmtthws
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fontconfig has a bug in FcFini() where it calls assert when it probably shouldn't. This looks to be fixed in
https://gitlab.freedesktop.org/fontconfig/fontconfig/-/commit/6f6b39780215714386606ca1c5457a7106639ff4, which is in libfontconfig >=2.13.93.
Removing this seems to be safe, it will cause valgrind to show mem leaks, but it doesn't look to be a problem in practice.