Add support for power_now #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C language defines long to be at least 32 bit and so on ILP32 data models like Win32 and 32-bit Unix systems. It therefore will overflow for values of the order of 1e12, which we obtain as a multiplication result in get_battery_power_draw(). Fix this by an early conversion to double.
Not all systems report current_now through the power supply sysfs interface, but some do report power_now instead. Add support for these, too. The new implementation first tries power_now and then falls back to computing power as the product of current and voltage. The new implementation also reduces memory footprint on the stack by some 512k. Also the old implementation potentially left files open under some circumstances.
✅ Deploy Preview for conkyweb canceled.
|
brndnmtthws
approved these changes
Dec 3, 2024
brndnmtthws
added
the
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/has been updatedDescription