Add compiler cache and fix CMake deprecation warnings #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix use of deprecated `exec_program`. - Reformat 'UninstallConky.cmake.in' file. - Separate BUILD_TESTS (now BUILD_TESTING to shadow CTest variable) from MAINTAINER_MODE flag. - Remove BUILD_TESTS flag from CI, default it already true. - Add support for (s)ccache, enable it by default. - Add REPRODUCIBLE_BUILD to disable (s)ccache default. - Set REPRODUCIBLE_BUILD=ON in nix flake. - Add CI detection for possible future use, stored in ENV_IS_CI variable. - Minor formatting tweaks. Signed-off-by: Tin Švagelj <[email protected]>
github-actions
bot
added
sources
✅ Deploy Preview for conkyweb canceled.
|
Caellian
added
the
enhancement
Caellian
force-pushed
the
dev/cmake-improvements
branch
5 times, most recently
from
23abead to
9f8a172
Compare
Signed-off-by: Tin Švagelj <[email protected]>
Caellian
force-pushed
the
dev/cmake-improvements
branch
from
9f8a172 to
8b2700b
Compare
- Add cache action to compiler to pass cache across runs. Signed-off-by: Tin Švagelj <[email protected]>
Caellian
force-pushed
the
dev/cmake-improvements
branch
5 times, most recently
from
00d5aa4 to
905d3ff
Compare
brndnmtthws
approved these changes
Jan 5, 2025
Caellian
force-pushed
the
dev/cmake-improvements
branch
7 times, most recently
from
71c0519 to
296b899
Compare
Signed-off-by: Tin Švagelj <[email protected]>
Caellian
force-pushed
the
dev/cmake-improvements
branch
from
296b899 to
815c539
Compare
- Print sometimes useful cache hit stats after build. Signed-off-by: Tin Švagelj <[email protected]>
Caellian
force-pushed
the
dev/cmake-improvements
branch
from
8918ac6 to
344be5d
Compare
In theory, if 10 PRs make a whole bunch of pushes, it's possible one might lose cache history and have to build from scratch. Compression makes that less likely, but binary data is being compressed anyway so... not that much less likely. Signed-off-by: Tin Švagelj <[email protected]>
Signed-off-by: Tin Švagelj <[email protected]>
Caellian
force-pushed
the
dev/cmake-improvements
branch
13 times, most recently
from
4dc2e1d to
e0cd00e
Compare
Signed-off-by: Tin Švagelj <[email protected]>
Caellian
force-pushed
the
dev/cmake-improvements
branch
from
e0cd00e to
678d130
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exec_program.This commit addresses some issues raised in #2131. Namely, CMake will now produce warnings when building with MAINTAINER_MODE. And I added comments saying package maintainers shouldn't be using the MAINTAINER_MODE flag, as well as making the description more clear.