Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blame ignore & labeler #2133

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Update blame ignore & labeler #2133

merged 2 commits into from
Jan 5, 2025

Conversation

Caellian
Copy link
Collaborator

@Caellian Caellian commented Jan 5, 2025

This is a patch for #2119 PR, that adds "copied" commits to the .git-blame-ignore-revs file.

Also updates labeler.

Signed-off-by: Tin Švagelj <[email protected]>
@Caellian Caellian requested a review from brndnmtthws January 5, 2025 15:56
Copy link

netlify bot commented Jan 5, 2025

Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit e4e393d
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/677ab56725e6990008678b04

@github-actions github-actions bot added the gh-actions suggest changing GitHub actions label Jan 5, 2025
@Caellian Caellian changed the title Update blame ignore Update blame ignore & labeler Jan 5, 2025
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian Caellian force-pushed the dev/update-blame-ignore branch from a84ffd9 to e4e393d Compare January 5, 2025 16:37
Copy link
Owner

@brndnmtthws brndnmtthws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner, thanks!

@Caellian Caellian merged commit 7fd5dcb into main Jan 5, 2025
38 checks passed
@Caellian Caellian deleted the dev/update-blame-ignore branch January 5, 2025 19:46
@Caellian
Copy link
Collaborator Author

Caellian commented Jan 6, 2025

Much cleaner, thanks!

@brndnmtthws It didn't take me as long as I initially expected to fix all the paths in CMake. I got an idea of using a script to do it automatically and then generated it with an LLM. It was wrong, of course, but took me 95% of the way there. Then generated the other script to update import statements (also wrong, but CI helped a lot and build caching sped things up tremendously). Most difficult part was not getting carried away and touching up random files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gh-actions suggest changing GitHub actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants