Skip to content
This repository has been archived by the owner on Dec 14, 2017. It is now read-only.

Support for Account approval proccess #634

Merged
merged 3 commits into from
Sep 5, 2016
Merged

Conversation

christianacca
Copy link
Collaborator

See #632

@christianacca
Copy link
Collaborator Author

PR summary

  • modify existing APIs:
    • add two methods to UserAccountService - ApproveAccount, RejectAccount
    • add two mapped DateTime? properties to UserAccount - AccountApproved, AccountRejected
    • add two computed properties to UserAccount - IsAccountApproved, IsAccountRejected
    • add two classes - AccountApprovedEvent, AccountRejectedEvent
    • add two overloads to EmailAccountEventsHandler for the two new event classes above
    • add MembershipRebootConfiguration.RequireAccountApproval
    • add SecuritySettings.RequireAccountApproval
    • add necessary MR constants to support above
    • obsolete MembershipRebootConfiguration.AllowLoginAfterAccountCreation
  • add additional localized validation messages
  • add email templates for the new events
  • add EF migrations for two new (nullable) columns in the UserAccount table
  • add tests for new feature and make all existing tests pass
  • ensure backwards compatibility

@christianacca
Copy link
Collaborator Author

Hi @brockallen, a decision needs to be made whether - feat(EmailNotification): send email when account is unlocked (or 277607b) - over on master is a breaking change.

My gut feel is that it is a breaking change - the new emails that would be sent would not follow any branding customizations that maybe being applied by host app using MR.

If it is I'll update the nuspec files accordingly on master, then update this PR before merging into master...

If I don't here back (which is fine of course), I'll take a safe position and update the nuspec files to be a breaking change.

…Creation

If previously you set `AllowLoginAfterAccountCreation` to false, you
should instead:
* set `MembershipRebootConfiguration.RequireAccountApproval` to true
* replace the call to `UserAccountService.SetIsLoginAllowed` with
`UserAccountService.ApproveAccount` in order to allow login
@christianacca christianacca merged commit f9b3157 into master Sep 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants