Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful termination of shell scripts #1644

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

shahzebsiddiqui
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (7691771) 78.43% compared to head (aa3fd92) 78.74%.
Report is 54 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1644      +/-   ##
==========================================
+ Coverage   78.43%   78.74%   +0.32%     
==========================================
  Files          57       57              
  Lines        6647     6756     +109     
==========================================
+ Hits         5213     5320     +107     
- Misses       1434     1436       +2     
Files Coverage Δ
buildtest/cli/__init__.py 97.60% <ø> (ø)
buildtest/cli/build.py 96.27% <100.00%> (-0.01%) ⬇️
buildtest/cli/buildspec.py 96.88% <100.00%> (+3.01%) ⬆️
buildtest/cli/cdash.py 88.78% <100.00%> (+0.06%) ⬆️
buildtest/cli/path.py 100.00% <100.00%> (ø)
buildtest/cli/show.py 100.00% <100.00%> (ø)
buildtest/builders/base.py 89.29% <88.89%> (-0.13%) ⬇️
buildtest/cli/config.py 88.80% <96.15%> (+1.93%) ⬆️
buildtest/config.py 52.36% <87.50%> (+1.38%) ⬆️
buildtest/builders/script.py 73.20% <5.56%> (-15.41%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 20, 2023
@shahzebsiddiqui shahzebsiddiqui merged commit c106256 into devel Oct 24, 2023
28 checks passed
@shahzebsiddiqui shahzebsiddiqui deleted the graceful_termination_shellscript_with_trap branch October 24, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant