Update GitLab CI/CD script #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @paulRbr , I've open this PR following yesterday discussions. WDYT of these suggestions? May I ask your help about why circleCI failed (no change in this PR at first sight) 🙏 |
paulRbr
reviewed
Jun 11, 2024
paulRbr
reviewed
Jun 11, 2024
.gitlab-ci.yml
Outdated
|
|
||
| diff_doc: | ||
| stage: test | ||
| script: | ||
| - ./.gitlab/diff-comment-mr.sh bump.openapi.v3.yml | ||
| - ./.gitlab/diff-comment-mr.sh 'bump.openapi.v3.yml' bump_token |
There was a problem hiding this comment.
Instead of adding a comment in the sh script, you can call sh here directly which removes the necessity for the execution flag on the script file:
Suggested change
| - ./.gitlab/diff-comment-mr.sh 'bump.openapi.v3.yml' bump_token | |
| - sh ./.gitlab/diff-comment-mr.sh "bump.openapi.v3.yml" "bump_documentation_slug" "bump_token" |
There was a problem hiding this comment.
Thanks for suggestion and comment, I've adapted script consequently.
- run script with
shand remove comment aboutchmode - adapt call to this script, with 3 parameters
"bump.openapi.v3.yml" "bump_documentation_slug" "bump_token"
Polo2
force-pushed
the
update-gitlab-cicd-script
branch
from
f563981 to
5dc617f
Compare
paulRbr
reviewed
Jun 11, 2024
Current script assumes that node package bump-cli is installed in the application where this GitLab CI/CD script is used, hence the presence of a 'package.json' configuration file. But this script can also be run with more simplicity: package 'bump-cli' is found and installed by npm during CI/CD process.
Add parameters documentation_slug and bump_token. These can be defined with GitLab CI/CD variables: https://docs.gitlab.com/ee/ci/variables/index.html#protect-a-cicd-variable And add double quotes around 'path/to/specification', required to run script on GitLab. Call 'diff-comment-mr' file script with `sh`, no need to update rights to be executable.
Polo2
force-pushed
the
update-gitlab-cicd-script
branch
from
5dc617f to
c66af19
Compare
paulRbr
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Everything seems to be fine on https://gitlab.com/bump-sh/bump-ci-example/-/merge_requests/3
let's merge this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some suggestions noticed by testing the script on a test repository on GitLab:
bump-clipackage in 'package.json'shto call 'diff-comment-mr.sh' and thus override execution rights missing (or it crashes, cf this job )