Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting x-state in the help center #319

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grossyoan
Copy link
Contributor

@grossyoan grossyoan commented Jan 17, 2025

Hi!

I pushed a first draft to add the x-state in the documentation.

While writing it, I was wondering if it wouldn't make sense to have a global category (instead of Beta) that talks about the x-state and the x-beta, as the two can be combined.

It's also quite a long content, if we want to show a code example (and I think that's really important)

For now, I added it in the "Speficication extensions" page.

@grossyoan grossyoan requested a review from jayk-u January 17, 2025 11:15
Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for bump-content-hub ready!

Name Link
🔨 Latest commit 7ecee07
🔍 Latest deploy log https://app.netlify.com/sites/bump-content-hub/deploys/678a3bdda317a7000881596d
😎 Deploy Preview https://deploy-preview-319--bump-content-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Current definition URL. It should be accessible through HTTP by Bump.sh servers.
```

Adding or removing this property is a structural change.
Copy link
Contributor

@ChristopheDujarric ChristopheDujarric Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

structural change

I recommend that we clarify what this means and what is the impact.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we would have to do the same for beta (I took this sentence from there).

@@ -24,6 +24,46 @@ This custom property allows you to identify some components of your
documentation as beta. Find out more in our [dedicated
section](/help/specification-support/doc-beta).

## Give precision to the state of your features (`x-state`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the wording could be more impactful here.
Our users have often referred to this feature as “badges.” Therefore, I’d lean towards something like “Operation Status Badges”, “Endpoint Status Badges", or even "Status Badges". Or maybe something around "tag" ?

It should be something easily searchable using terms like “status” or “badge.”

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully agree that it should be mentioned up there!

As of 'tags' or 'badges', you're also right. Badges are tags you can't interact with. So we should harmonize to 'badges' everywhere.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you share a link to this example, I may be able to suggest a better screenshot. For instance, I could check if it’s the right dimensions, follows the appropriate template, and perhaps add a highlight to emphasize the badge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent you the API, if you want a better image 😌

@@ -24,6 +24,46 @@ This custom property allows you to identify some components of your
documentation as beta. Find out more in our [dedicated
section](/help/specification-support/doc-beta).

## Give precision to the state of your features (`x-state`)

This custom property can be added inside an operation or a property to identify it with a custom tag.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have added some contextual elements around the feature, such as use cases or examples of how it could be valuable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the use cases from this week's lead.
For existing clients, it was use to mention the version of the API this element was added in ("Added in 1.2.3"), or to mention a "Technical Preview", so to explain that it's still under heavy development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants