Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libav #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Libav #1

wants to merge 4 commits into from

Conversation

c9o
Copy link
Owner

@c9o c9o commented Jul 30, 2024

No description provided.

Jingtao Chen added 4 commits July 24, 2015 15:43
replace mime with format
e006602 
Signed-off-by: Jingtao Chen <[email protected]>
start time
c0da61c 
Signed-off-by: Jingtao Chen <[email protected]>
Add audio channels
1abcf29 
Signed-off-by: Jingtao Chen <[email protected]>
Add COPYING
47b1e2a 
Change-Id: I5ef536807c3fe2544265faeae6dc7aafd1460e15
Signed-off-by: Jingtao Chen <[email protected]>
@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

25 similar comments
@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Jul 30, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Preparing review...

1 similar comment
@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Persistent review updated to latest commit 47b1e2a

4 similar comments
@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Persistent review updated to latest commit 47b1e2a

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Persistent review updated to latest commit 47b1e2a

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Persistent review updated to latest commit 47b1e2a

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Persistent review updated to latest commit 47b1e2a

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Generating PR code suggestions

Work in progress ...

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Persistent review updated to latest commit 47b1e2a

1 similar comment
@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Persistent review updated to latest commit 47b1e2a

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Preparing PR description...

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Generating PR code suggestions

Work in progress ...

2 similar comments
@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Generating PR code suggestions

Work in progress ...

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Generating PR code suggestions

Work in progress ...

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Preparing review...

2 similar comments
@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Persistent review updated to latest commit 47b1e2a

1 similar comment
@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Persistent review updated to latest commit 47b1e2a

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Persistent review updated to latest commit 47b1e2a

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Persistent review updated to latest commit 47b1e2a

1 similar comment
@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Persistent review updated to latest commit 47b1e2a

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Preparing review...

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Persistent review updated to latest commit 47b1e2a

2 similar comments
@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Persistent review updated to latest commit 47b1e2a

@c9o
Copy link
Owner Author

c9o commented Aug 1, 2024

Persistent review updated to latest commit 47b1e2a

@c9o
Copy link
Owner Author

c9o commented Aug 5, 2024 •
edited
Loading

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Enhancement
Add logging to clarify the function's behavior

Improve the clarity of the comments and ensure they match the actual code behavior.

lib/mediainfo.c [94-99]

 92  /* "user interface" functions */
 93  static void dump_stream_format(AVFormatContext *ic, int i, int index, int is_output)
 94  {
 95  	AVStream *st = ic->streams[i];
 96  	AVDictionaryEntry *lang = av_dict_get(st->metadata, "language", NULL, 0);
-97
-98  }
+97  	if (lang) {
+98     printf("Found language: %s\n", lang->value);
+99   }
Suggestion importance[1-10]: 7

Why: The comments do not accurately reflect the actual code behavior. Adding logging can clarify the function's behavior.

7
Documentation
Add documentation comments for the new metadata keys

Ensure consistent use of comments and add missing documentation for the new metadata
keys.

lib/mediainfo.h [36-66]

 30  	METADATA_KEY_HAS_VIDEO				,
 31  	METADATA_KEY_HAS_AUDIO				,
 32  	METADATA_KEY_VIDEO_CODEC			,
 33  	METADATA_KEY_AUDIO_CODEC			,
 34  	METADATA_KEY_VIDEO_PROFILE			,
 35  	METADATA_KEY_AUDIO_PROFILE			,
 36  	METADATA_KEY_FILE_FORMAT			,
-37  	METADATA_KEY_HAS_VIDEO				,
-38  	METADATA_KEY_HAS_AUDIO				,
-39  	METADATA_KEY_VIDEO_CODEC			,
-40  	METADATA_KEY_AUDIO_CODEC			,
-41  	METADATA_KEY_VIDEO_PROFILE			,
-42  	METADATA_KEY_AUDIO_PROFILE			,
-43  	METADATA_KEY_WIDTH				,
-44  	METADATA_KEY_HEIGHT				,
-45  	METADATA_KEY_TBN				,
-46  	METADATA_KEY_TBC				,
-47  	METADATA_KEY_PAR				,
-48  	METADATA_KEY_DAR				,
-49  	METADATA_KEY_TITLE				,
-50  	METADATA_KEY_ALBUM				,
-51  	METADATA_KEY_ARTIST				,
-52  	METADATA_KEY_GENRE				,
-53  	METADATA_KEY_ALBUMARTIST			,
-54  	METADATA_KEY_LANGUAGE				,
-55  	METADATA_KEY_CD_TRACK_NUMBER			,
-56  	METADATA_KEY_DATE				,
-57  	METADATA_KEY_TYER				,
-58  	METADATA_KEY_COMMENT				,
-59  	METADATA_KEY_TAGGING_TIME			,
-60  	METADATA_KEY_TOOL_NAME				,
-61  	METADATA_KEY_ENCODER				,
-62  	METADATA_KEY_YEAR				,
-63  	METADATA_KEY_COMPOSER				,
-64  	METADATA_KEY_ORGANIZATION			,
-65  	METADATA_KEY_AUTHOR				,
-66  	METADATA_KEY_COPYRIGHT				= 37,
+37  	// Documentation for FILE_FORMAT
+38  	METADATA_KEY_HAS_VIDEO				,
+39  	METADATA_KEY_HAS_AUDIO				,
+40  	METADATA_KEY_VIDEO_CODEC			,
+41  	METADATA_KEY_AUDIO_CODEC			,
+42  	METADATA_KEY_VIDEO_PROFILE			,
+43  	METADATA_KEY_AUDIO_PROFILE			,
+44  	METADATA_KEY_WIDTH				,
+45  	METADATA_KEY_HEIGHT				,
+46  	METADATA_KEY_TBN				,
+47  	METADATA_KEY_TBC				,
+48  	METADATA_KEY_PAR				,
+49  	METADATA_KEY_DAR				,
+50  	METADATA_KEY_TITLE				,
+51  	METADATA_KEY_ALBUM				,
+52  	METADATA_KEY_ARTIST				,
+53  	METADATA_KEY_GENRE				,
+54  	METADATA_KEY_ALBUMARTIST			,
+55  	METADATA_KEY_LANGUAGE				,
+56  	METADATA_KEY_CD_TRACK_NUMBER			,
+57  	METADATA_KEY_DATE				,
+58  	METADATA_KEY_TYER				,
+59  	METADATA_KEY_COMMENT				,
+60  	METADATA_KEY_TAGGING_TIME			,
+61  	METADATA_KEY_TOOL_NAME				,
+62  	METADATA_KEY_ENCODER				,
+63  	METADATA_KEY_YEAR				,
+64  	METADATA_KEY_COMPOSER				,
+65  	METADATA_KEY_ORGANIZATION			,
+66  	METADATA_KEY_AUTHOR				,
+67  	METADATA_KEY_COPYRIGHT				= 37,
Suggestion importance[1-10]: 6

Why: The comments are inconsistent and missing documentation for new metadata keys. Adding documentation can improve clarity and maintainability.

6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Review effort [1-5]: 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@c9o