Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: typescript error #134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: typescript error #134

wants to merge 2 commits into from

Conversation

mrdeleon
Copy link

Fix: added ariaBrailleLabel, ariaBrailleRoleDescription to ElementInternals
Update: added ariaBrailleLabel, ariaBrailleRoleDescription to aom const
Update: added ariaBrailleLabel, ariaBrailleRoleDescription to IAom interface

Screenshot 2024-08-30 at 11 17 28 AM

@mrdeleon
Copy link
Author

Depending on the version of typescript you will get a different type error. For version 4.9.4 which I have locally right now the screenshot in the PR is the error.

For version 5.5.4 of typescript which I have in a different project it is missing ariaBrailleRoleDescriptions (with an 's') as well.

@calebdwilliams
Copy link
Owner

My biggest issue is this doesn't actually solve the issue we're having. What we need to do is patch the global object and make the polyfill more robust. I've been playing with that a bit, but I honestly don't have a ton of time to devote to open source right now.

@calebdwilliams
Copy link
Owner

I have a version of this in progress on the fix-ts branch if you want to look at it to see if it fixes your issues. I'm working through how best to test this right now.

1 similar comment
@calebdwilliams
Copy link
Owner

I have a version of this in progress on the fix-ts branch if you want to look at it to see if it fixes your issues. I'm working through how best to test this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants