Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor iterable #778

Merged
merged 19 commits into from
Jan 6, 2024
Merged

Refactor iterable #778

merged 19 commits into from
Jan 6, 2024

Conversation

MarcelGarus
Copy link
Member

Closes: #776

Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@jwbot jwbot enabled auto-merge October 26, 2023 18:58
@jwbot jwbot added P: Core Package: Candy's standard library P: Builtins Package exposing Candy's compiler builtins P: Random Package: Random P: Examples Package: Examples P: ProgrammingLanguageBenchmarks Package: Candy implementations of algorithms from the Programming Language Benchmarks website P: RosettaCode Package: Candy implementations of problems from Rosetta Code labels Oct 26, 2023
JonasWanke
JonasWanke requested changes Oct 26, 2023
View reviewed changes
packages/Random/rngs/pseudo/xorshift.candy Outdated Show resolved Hide resolved
packages/Core/iterator.candy Outdated Show resolved Hide resolved
packages/Core/iterator.candy Show resolved Hide resolved
packages/Core/iterator.candy Outdated Show resolved Hide resolved
@jwbot jwbot added P: Compiler: Frontend Package: The compiler frontend P: Compiler: VM Package: The VM executing Candy byte code (LIR) labels Oct 27, 2023
@jwbot
Copy link
Collaborator

jwbot commented Oct 27, 2023

The golden IRs have changed: 5396ec6..18a279b

@MarcelGarus
Copy link
Member Author

Some notes for changes that don't fit the PR title:

@jwbot
Copy link
Collaborator

jwbot commented Oct 27, 2023

The golden IRs have changed: 5396ec6..03e9f96

@jwbot
Copy link
Collaborator

jwbot commented Oct 27, 2023

The golden IRs have changed: 7535661..1ce8c93

@jwbot
Copy link
Collaborator

jwbot commented Oct 27, 2023

The golden IRs have changed: 7535661..17ebb47

@MarcelGarus
Copy link
Member Author

Surprisingly, wrapSafe doesn't seem to impact performance too badly and it results in a much better dev experience when errors occur. That's why I'm inclined to leave it in for now.

JonasWanke
JonasWanke reviewed Oct 27, 2023
View reviewed changes
compiler/vm/src/heap/object_inline/int.rs Outdated Show resolved Hide resolved
packages/Core/iterator.candy Outdated Show resolved Hide resolved
@jwbot jwbot removed P: Compiler: Frontend Package: The compiler frontend P: Compiler: VM Package: The VM executing Candy byte code (LIR) labels Jan 6, 2024
@jwbot
Copy link
Collaborator

jwbot commented Jan 6, 2024

The golden IRs have changed: c1f8e4e..c133bc3

@MarcelGarus MarcelGarus requested a review from JonasWanke January 6, 2024 11:35
@jwbot jwbot merged commit 8885300 into main Jan 6, 2024
12 checks passed
@jwbot jwbot deleted the refactor-iterable branch January 6, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasWanke JonasWanke JonasWanke approved these changes

Assignees

@MarcelGarus MarcelGarus

Labels
P: Builtins Package exposing Candy's compiler builtins P: Core Package: Candy's standard library P: Examples Package: Examples P: ProgrammingLanguageBenchmarks Package: Candy implementations of algorithms from the Programming Language Benchmarks website P: Random Package: Random P: RosettaCode Package: Candy implementations of problems from Rosetta Code
Projects
🍭 Candy
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Iterator
3 participants
@MarcelGarus @jwbot @JonasWanke