Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade eslint packages #2054

Merged
merged 1 commit into from
Jan 14, 2025
Merged

upgrade eslint packages #2054

merged 1 commit into from
Jan 14, 2025
+371 −272

Conversation

abbiesims
Copy link
Contributor

@abbiesims abbiesims commented Jan 13, 2025 •
edited
Loading

Done

  • Upgrades the following packages:

    • eslint
    • eslint-plugin-jest
    • stylelint-config-standard-scss
    • flake8

  • Also modifies a lot of linting errors that came with the upgrades, as well as the lint-js command in package.json

How to QA

  • Make sure all tests and linting jobs pass
  • Click around the demo to make sure things are functioning as before

Testing

  • This PR has tests
  • No testing required (explain why):

Issue / Card

Splitting up larger renovate PR

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@abbiesims abbiesims marked this pull request as ready for review January 13, 2025 14:19
steverydz
steverydz approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@abbiesims abbiesims merged commit 1e849cc into feature/update-dependencies Jan 14, 2025
10 checks passed
@abbiesims abbiesims deleted the upgrade-eslint branch January 14, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steverydz steverydz steverydz approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abbiesims @webteam-app @steverydz