Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inspection script #372

Merged
merged 40 commits into from
May 5, 2024
Merged

Add inspection script #372

merged 40 commits into from
May 5, 2024

Conversation

eaudetcobello
Copy link
Contributor

@eaudetcobello eaudetcobello commented Apr 24, 2024

Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going in the right direction.

Please also collect the SBOM and the k8sd database content and updated the bug template.
Also, the scripts directory is not included in the snap. Move this folder in the k8s directory or add a new entry in the snapcraft.yaml

@eaudetcobello eaudetcobello requested review from bschimke95 and removed request for bschimke95 April 25, 2024 17:44
@eaudetcobello eaudetcobello marked this pull request as ready for review April 26, 2024 13:07
@eaudetcobello eaudetcobello requested a review from a team as a code owner April 26, 2024 13:07
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going in the right direction, but needs work

.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
k8s/scripts/inspect.sh Outdated Show resolved Hide resolved
k8s/scripts/inspect.sh Outdated Show resolved Hide resolved
k8s/scripts/inspect.sh Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
k8s/scripts/inspect.sh Outdated Show resolved Hide resolved
k8s/scripts/inspect.sh Outdated Show resolved Hide resolved
k8s/scripts/inspect.sh Outdated Show resolved Hide resolved
k8s/scripts/inspect.sh Outdated Show resolved Hide resolved
k8s/scripts/inspect.sh Show resolved Hide resolved
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eaudetcobello eaudetcobello force-pushed the eaudetcobello/KU-569 branch from 1eca07f to b0d6811 Compare May 2, 2024 12:21
@eaudetcobello eaudetcobello requested a review from bschimke95 May 2, 2024 12:24
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is more info we should be gathering to be able to get good understanding of the system, particularly around the networking of the host.

let's include the outputs of ip a, ip r, iptables, ss -plnt

k8s/scripts/inspect.sh Show resolved Hide resolved
k8s/scripts/inspect.sh Outdated Show resolved Hide resolved
@eaudetcobello eaudetcobello force-pushed the eaudetcobello/KU-569 branch from f5bc068 to f22383e Compare May 2, 2024 12:59
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work! Just a final comment

k8s/scripts/inspect.sh Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented May 5, 2024

Package Line Rate
github.com/canonical/k8s/api/v1 35%
github.com/canonical/k8s/cmd/k8s-apiserver-proxy 0%
github.com/canonical/k8s/cmd/k8s 37%
github.com/canonical/k8s/cmd/k8sd 0%
github.com/canonical/k8s/cmd 0%
github.com/canonical/k8s/cmd/util 15%
github.com/canonical/k8s/pkg/client/dqlite 48%
github.com/canonical/k8s/pkg/client/helm 5%
github.com/canonical/k8s/pkg/client/helm/mock 100%
github.com/canonical/k8s/pkg/client/kubernetes 69%
github.com/canonical/k8s/pkg/k8s/client 0%
github.com/canonical/k8s/pkg/k8s/client/mock 8%
github.com/canonical/k8s/pkg/k8sd/api 14%
github.com/canonical/k8s/pkg/k8sd/api/impl 0%
github.com/canonical/k8s/pkg/k8sd/app 11%
github.com/canonical/k8s/pkg/k8sd/controllers 45%
github.com/canonical/k8s/pkg/k8sd/database 48%
github.com/canonical/k8s/pkg/k8sd/database/util 0%
github.com/canonical/k8s/pkg/k8sd/features 4%
github.com/canonical/k8s/pkg/k8sd/pki 52%
github.com/canonical/k8s/pkg/k8sd/setup 77%
github.com/canonical/k8s/pkg/k8sd/types 78%
github.com/canonical/k8s/pkg/proxy 6%
github.com/canonical/k8s/pkg/snap/mock 85%
github.com/canonical/k8s/pkg/snap 17%
github.com/canonical/k8s/pkg/snap/util 90%
github.com/canonical/k8s/pkg/utils 60%
github.com/canonical/k8s/pkg/utils/control 100%
github.com/canonical/k8s/pkg/utils/errors 100%
github.com/canonical/k8s/pkg/utils/experimental/snapdconfig 12%
github.com/canonical/k8s/pkg/utils/node 0%
github.com/canonical/k8s/pkg/utils/shims 0%
Summary 37% (2545 / 6847)

@eaudetcobello eaudetcobello merged commit 270177c into main May 5, 2024
8 checks passed
@eaudetcobello eaudetcobello deleted the eaudetcobello/KU-569 branch May 5, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants