Cleans up k8s-dqlite state dir and stops it on remove hook #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiubelu
force-pushed
the
remove-hook-updates
branch
from
a443e95 to
8b30ce4
Compare
claudiubelu
changed the title
bschimke95
reviewed
Dec 17, 2024
claudiubelu
force-pushed
the
remove-hook-updates
branch
2 times, most recently
from
ac8315e to
589184a
Compare
claudiubelu
changed the title
berkayoz
reviewed
Jan 8, 2025
cfg.Datastore.GetType() may return an empty string if the bootstrap action failed before database.SetClusterConfig has been called. Because of this, we're not removing the state dir for k8s-dqlite, which will be wrongfully removed by setup.K8sDqlite on the next bootstrap attempt. We're now opportunistically cleaning up the k8s-dqlite related state directory. If a bootstrap attempt fails, the k8s-dqlite service will still be running, which will cause the next bootstrap attempt to fail, as the k8s-dqlite port will be currently in use.
claudiubelu
force-pushed
the
remove-hook-updates
branch
from
589184a to
7787d45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfg.Datastore.GetType()may return an empty string if the bootstrap action failed beforedatabase.SetClusterConfighas been called. Because of this, we're not removing the state dir for k8s-dqlite, which will be wrongfully removed bysetup.K8sDqliteon the next bootstrap attempt.We're now opportunistically cleaning up the
k8s-dqliterelated state directory.If a bootstrap attempt fails, the
k8s-dqliteservice will still be running, which will cause the next bootstrap attempt to fail, as thek8s-dqliteport will be currently in use.