-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ipv6 load balancer tests #926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @petrutlucian94
Added a couple of comments. Please also move the year change to a separate PR. Thanks!
I had to run |
ad7bf49
to
ca4535b
Compare
looks like the |
I'll rebase the PR to get the metallb logs, fwiw it passed locally. |
We're adjusting the load balancer tests and related utils to also cover ipv6. This is currently wip as we're hitting the following Cilium issue: * cilium/cilium#15082 * cilium/cilium#17240
* add a "network type" param to the lb test * move header bump to separate PR * update ipv6 cidr
ca4535b
to
48dfc61
Compare
Strange, the test passes locally and the metallb logs seem fine. The lb ip gets assigned properly, however it's not accessible, but only in case of a dualstack environments.
I think I'll have to use this to take a look inside the GH runner: https://github.com/mxschmitt/action-tmate |
e2a7d32
to
6ebcec8
Compare
6ebcec8
to
b94ded9
Compare
The dualstack test uses a separate bridge, so the Docker workaround had to be applied there as well. Thanks @berkayoz for the suggestion! |
Interesting,
I see a permission error:
We should probably disable this test since the |
The "strict" test jobs are currently disabled, except for "test_strict_interfaces", which is now failing. We'll disable this test as well until we get to fix the "strict" channel, which is currently low-prio.
It is fine to disable the test for now but we should still be aware of such issues. I created a card to investigate this in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds ipv6-only and ipv6-dualstack load balancer tests. Note that the ipv6-only test is currently skipped due to a known cilium limitation: