Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add snap upgrades how-to #934

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

HomayoonAlimohammadi
Copy link
Contributor

Overview

This PR adds a how-to guide on snap upgrades.

@HomayoonAlimohammadi HomayoonAlimohammadi requested a review from a team as a code owner January 8, 2025 14:28
@HomayoonAlimohammadi HomayoonAlimohammadi force-pushed the KU-2420/snap-upgrades-how-to branch from b1095aa to 4929fd7 Compare January 8, 2025 14:30
@HomayoonAlimohammadi HomayoonAlimohammadi force-pushed the KU-2420/snap-upgrades-how-to branch from 4929fd7 to c369bb0 Compare January 8, 2025 14:39
Copy link
Contributor

@nhennigan nhennigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Few small changes suggested 😸

docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
docs/src/snap/howto/upgrades.md Show resolved Hide resolved
docs/src/snap/howto/index.md Outdated Show resolved Hide resolved
docs/src/snap/howto/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work Hue! Left you some minor comments.

docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, minor comments
Great work @HomayoonAlimohammadi

docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hue! Some final comments:

docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
docs/src/snap/howto/upgrades.md Show resolved Hide resolved
docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
docs/src/snap/howto/upgrades.md Outdated Show resolved Hide resolved
@HomayoonAlimohammadi HomayoonAlimohammadi merged commit 3d29e50 into main Jan 9, 2025
6 checks passed
@HomayoonAlimohammadi HomayoonAlimohammadi deleted the KU-2420/snap-upgrades-how-to branch January 9, 2025 14:39
Comment on lines +11 to +17
- According to the [upstream Kubernetes][1], skipping **minor** versions while
upgrading is not supported. For more details, please visit the
[Version Skew Policy][2].
- Before performing an upgrade, it's important to back up the cluster data.
This can be done by following the steps outlined in the [backup guide][3].
- For more information on managing snap updates, please refer to the
[snap documentation][4].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- According to the [upstream Kubernetes][1], skipping **minor** versions while
upgrading is not supported. For more details, please visit the
[Version Skew Policy][2].
- Before performing an upgrade, it's important to back up the cluster data.
This can be done by following the steps outlined in the [backup guide][3].
- For more information on managing snap updates, please refer to the
[snap documentation][4].
- According to the [upstream Kubernetes], skipping **minor** versions while
upgrading is not supported. For more details, please visit the
[Version Skew Policy].
- Before performing an upgrade, it's important to back up the cluster data.
This can be done by following the steps outlined in the [backup guide].
- For more information on managing snap updates, please refer to the
[snap documentation].

Comment on lines +103 to +108
[1]: https://kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade/
[2]: https://kubernetes.io/docs/setup/release/version-skew-policy/
[3]: ./backup-restore.md
[4]: https://snapcraft.io/docs/managing-updates
[5]: ../../charm/index.md
[6]: ../../capi/index.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[1]: https://kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade/
[2]: https://kubernetes.io/docs/setup/release/version-skew-policy/
[3]: ./backup-restore.md
[4]: https://snapcraft.io/docs/managing-updates
[5]: ../../charm/index.md
[6]: ../../capi/index.md
[upstream Kubernetes]: https://kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade/
[Version Skew Policy]: https://kubernetes.io/docs/setup/release/version-skew-policy/
[backup guide]: ./backup-restore.md
[snap documentation]: https://snapcraft.io/docs/managing-updates
[5]: ../../charm/index.md
[6]: ../../capi/index.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think 5 and 6 are unused?

Patch upgrades address bug fixes and are typically safe, introducing no
breaking changes.
Snaps automatically check for updates of their specific track
(e.g. `1.32-classic`) several times a day and apply them when available.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(e.g. `1.32-classic`) several times a day and apply them when available.
(e.g. `1.32-classic`) 4 times a day and apply them when available.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I initially had, but changed according to this comment: #934 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants