Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add how-to uninstall the snap section #941

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Conversation

bschimke95
Copy link
Contributor

A brief docs page that explains how to (completely) remove the k8s snap.

@bschimke95 bschimke95 requested a review from a team as a code owner January 9, 2025 10:45
Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks a lot @bschimke95! LGTM, just a minor comment.

docs/src/snap/howto/install/uninstall.md Outdated Show resolved Hide resolved
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben, please consider my suggestions and then send it on its way!

docs/src/snap/howto/install/uninstall.md Outdated Show resolved Hide resolved
docs/src/snap/howto/install/uninstall.md Outdated Show resolved Hide resolved
docs/src/snap/howto/install/uninstall.md Outdated Show resolved Hide resolved
docs/src/snap/howto/install/uninstall.md Outdated Show resolved Hide resolved
@bschimke95
Copy link
Contributor Author

Waiting for @nhennigan for the final approval :)

Copy link
Contributor

@nhennigan nhennigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments and then you can go ahead and merge 😃

docs/src/snap/howto/install/uninstall.md Outdated Show resolved Hide resolved
docs/src/snap/howto/install/uninstall.md Outdated Show resolved Hide resolved
@bschimke95 bschimke95 merged commit 6087231 into main Jan 10, 2025
5 of 6 checks passed
@bschimke95 bschimke95 deleted the KU-2396/uninstall-snap branch January 10, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants