Simplify the docs for installing via terraform #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
approved these changes
Jan 13, 2025
| provider "juju" {} | ||
|
|
||
| resource "juju_model" "this" { | ||
| name = "juju-myk8s" # name of the juju model |
There was a problem hiding this comment.
this comment feels a bit redundant but I'm also fine with keeping it if you think we should
There was a problem hiding this comment.
Maybe a better name than this here? Maybe rather my-model?
| provider "juju" {} | ||
|
|
||
| resource "juju_model" "this" { | ||
| name = "juju-myk8s" # name of the juju model |
There was a problem hiding this comment.
Maybe a better name than this here? Maybe rather my-model?
Comment on lines
+43
to
+46
| variable "k8s" { | ||
| description = "K8s deployment shared configuration" | ||
| channel = string | ||
| default = "1.xx/stable" |
There was a problem hiding this comment.
I don't quite like this variable declaration here. First it should be in an input file and second this should be closer to where it is set >> sub-module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ensure that the user provides a deployment channel for the charms rather than rely on a default in the charm modules.
Details
terraform planbefore running apply