[Docs] Clarify node-labels are additive or destructive #949
+84
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
changed the title
|
This may need a troubleshooting page on its own. Right @nhennigan ? |
bschimke95
reviewed
Jan 13, 2025
| # Add/Remove custom node labels | ||
| # Using <key>=<value> one can ensure the label is added to all the nodes of this application | ||
| # Using <key>=- one can ensure the label is removed from all the nodes of this application | ||
| node-labels: "environment=production zone=us-east-1 node-role.kubernetes.io/worker=-" |
There was a problem hiding this comment.
I don't understand the use-case of the removal syntax. Could you elaborate on why this is needed?
A node-label that is not defined here is not set as part of the bootstrapping process. Why/from where should a node get the labels in that phase?
There was a problem hiding this comment.
Ah, do we apply those node-labels on top of the default labels?
| # Troubleshooting | ||
|
|
||
| This page provides techniques for troubleshooting common {{product}} | ||
| issues dealing specifically with the charm |
There was a problem hiding this comment.
nit: Missing . at the end
|
|
||
|
|
||
|
|
||
| <!-- LINKS --> |
There was a problem hiding this comment.
nit: I guess we don't need that.
| issues dealing specifically with the charm | ||
|
|
||
|
|
||
| ## Adjusting kubernetes node labels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Indicate to users that the charm config
node-labelsis both additive and destructive and can be used for either purpose.