Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve instance exec reliability on GitHub runners #624

Closed
wants to merge 4 commits into from

Conversation

hamistao
Copy link
Contributor

@hamistao hamistao commented Jan 9, 2025

Test failures such as https://github.com/canonical/lxd-ci/actions/runs/12665446559/job/35295166835#step:11:243 have been seen, only on GitHub runners.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.37%. Comparing base (42332f8) to head (3f1b591).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
- Coverage   95.44%   95.37%   -0.08%     
==========================================
  Files          32       32              
  Lines        3224     3240      +16     
==========================================
+ Hits         3077     3090      +13     
- Misses        147      150       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamistao hamistao force-pushed the fix_lxd-ci_tests branch 6 times, most recently from 31890c1 to 8f9d956 Compare January 10, 2025 02:28
@hamistao hamistao marked this pull request as ready for review January 10, 2025 02:29
@hamistao hamistao marked this pull request as draft January 10, 2025 02:44
@hamistao hamistao force-pushed the fix_lxd-ci_tests branch 4 times, most recently from 862a979 to 3f1b591 Compare January 12, 2025 01:13
@hamistao
Copy link
Contributor Author

Closing this as we determined the problem it is not a bug within pylxd and will be fixed on LXD.

@hamistao hamistao closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant