[DPE-5015] Fix integration hub not parsing equals sign properly #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deusebio
reviewed
Aug 2, 2024
|
Oki! Just realized that we don't have tests here. Let's then skip the tests here, but it would be good to have that tests in the integration hub. It should be pretty easy, we set the charm to populate a config with double equals, and we make sure that we can fetch that |
deusebio
approved these changes
Aug 2, 2024
|
@deusebio I have those tests in the Operator. Since there are no tests here, adding them from scratch felt more like a separate task with wider scope. Here is the PR: canonical/spark-integration-hub-k8s-operator#18 |
|
@deusebio yes yes, I noticed and I have revised my comment above and approved. We are on the same page, as you have already implemented the tests in the operator! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.