feat(firestore): include metadata property on snapshot (#567) #707
Conversation
The `source` option is only supported on the web platform and does not exist in the Android SDK.
.../main/java/io/capawesome/capacitorjs/plugins/firebase/firestore/FirebaseFirestoreHelper.java
Outdated
Show resolved
Hide resolved
|
Hope everything is right now. :-) |
phjardas
changed the title
source option (#567)
|
I'll have a go at the iOS implementation this afternoon. |
...pacitorjs/plugins/firebase/firestore/classes/options/AddDocumentSnapshotListenerOptions.java
Outdated
Show resolved
Hide resolved
...citorjs/plugins/firebase/firestore/classes/options/AddCollectionSnapshotListenerOptions.java
Outdated
Show resolved
Hide resolved
...js/plugins/firebase/firestore/classes/options/AddCollectionGroupSnapshotListenerOptions.java
Outdated
Show resolved
Hide resolved
|
Please run |
|
commit: @capacitor-firebase/analytics
@capacitor-firebase/app
@capacitor-firebase/app-check
@capacitor-firebase/authentication
@capacitor-firebase/crashlytics
@capacitor-firebase/firestore
@capacitor-firebase/functions
@capacitor-firebase/messaging
@capacitor-firebase/performance
@capacitor-firebase/remote-config
@capacitor-firebase/storage
|
|
@phjardas LGTM! You want to push the ios implementation on this branch too? |
Yeah, let's hope I find time tomorrow. I've never worked with Swift or iOS before. 😬 |
|
Let me know if you have any questions. ;) |
|
I just pushed the iOS implementation. It does build and verify, but I don't know how to actually test it. |
|
Oops. 🙈 I've added the missing code. I still don't understand how I could actually test this plugin with my real capacitor app to verify everything's working now. Can you give me a pointer? |
|
There are several ways to do this, the easiest is probably to simply use the pre-release, see https://github.com/capawesome-team/capacitor-firebase/runs/29462389318 |
|
Let me know as soon as you have tested it. |
|
✅ Tested successfully in a live app on Web, Android and iOS. |
|
BTW: this plugin and feature are used in rescuetablet.com ;-) |
|
That's awesome! 😍 Thank you for sharing! If you ever plan to deliver Live Updates, I would love to welcome you to Capawesome Cloud (the only live update solution that is EU based & hosted). 😆 |
|
Could you be so kind to soon make a patch release with this feature? 🙏🏻 We're currently using CapGo, and I'd rather not change the provider at this time. Unless you have very compelling arguments. 😜 |
* feat(firestore): include `metadata` property on snapshot * docs * feat(firestore): include metadata property on snapshot (#567) (#707) * Add Android, remove `source` option The `source` option is only supported on the web platform and does not exist in the Android SDK. * Revert omission of `source` option, complete Android implementation * pr updates * pr update * format code * Add iOS implementation * Add iOS implementation --------- Co-authored-by: Philipp Jardas <[email protected]>
Since all plugins are always updated at the same time, we wait until there are enough changes. Otherwise we would publish updates for 11 plugins for each change. ^^ I recommend that you use the pre-release until version 6.2.0 is published.
Feel free to reach out to me on LinkedIn. Maybe I can convince you. 😉 |
I've created the Android implementation based on your proposed interface. I've removed the
sourceoption because it is only supported on the web platform and does not exist in the Android SDK.