Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(authentication): add getIdTokenResult method #786

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(authentication): add getIdTokenResult method #786

wants to merge 8 commits into from

Conversation

josephgodwinkimani
Copy link

@josephgodwinkimani josephgodwinkimani commented Dec 28, 2024 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).
  • I have read and followed the pull request guidelines.

@josephgodwinkimani josephgodwinkimani mentioned this pull request Dec 28, 2024
Open
13 tasks
robingenz
robingenz requested changes Dec 30, 2024
View reviewed changes
packages/authentication/src/definitions.ts Outdated Show resolved Hide resolved
packages/authentication/src/definitions.ts Show resolved Hide resolved
packages/authentication/src/definitions.ts Outdated Show resolved Hide resolved
packages/authentication/src/definitions.ts Outdated Show resolved Hide resolved
packages/authentication/src/definitions.ts Outdated Show resolved Hide resolved
robingenz
robingenz requested changes Jan 3, 2025
View reviewed changes
Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the missing type GetIdTokenResultOptions, create a changeset (npm run changeset) and test your implementation.

packages/authentication/src/definitions.ts Outdated Show resolved Hide resolved
josephgodwinkimani
josephgodwinkimani commented Jan 3, 2025
View reviewed changes
Copy link
Author

@josephgodwinkimani josephgodwinkimani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the missing type GetIdTokenResultOptions

@robingenz
Copy link
Member

@josephgodwinkimani Please create a changeset using npm run changeset.

@robingenz
Copy link
Member

Thank you, i will merge it this week.

robingenz
robingenz requested changes Jan 11, 2025
View reviewed changes
Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just noticed that support for Android and iOS is missing. Please also add this since this plugin supports all 3 platforms.

.changeset/popular-cobras-camp.md Outdated Show resolved Hide resolved
packages/authentication/src/definitions.ts Outdated Show resolved Hide resolved
@robingenz
Copy link
Member

@josephgodwinkimani Let me know as soon as you're done and I can review it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robingenz robingenz robingenz requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephgodwinkimani @robingenz