Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add firestore & cloud storage error codes #789

Merged
merged 4 commits into from
Jan 11, 2025

Conversation

mamillastre
Copy link
Contributor

@mamillastre mamillastre commented Jan 3, 2025

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).
  • I have read and followed the pull request guidelines.

Close #788

Copy link

pkg-pr-new bot commented Jan 3, 2025

Open in Stackblitz

@capacitor-firebase/analytics

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/analytics@789

@capacitor-firebase/app

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/app@789

@capacitor-firebase/app-check

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/app-check@789

@capacitor-firebase/authentication

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/authentication@789

@capacitor-firebase/crashlytics

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/crashlytics@789

@capacitor-firebase/firestore

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/firestore@789

@capacitor-firebase/functions

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/functions@789

@capacitor-firebase/messaging

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/messaging@789

@capacitor-firebase/performance

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/performance@789

@capacitor-firebase/remote-config

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/remote-config@789

@capacitor-firebase/storage

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/storage@789

commit: ce475d1

Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mamillastre Have you tested your implementation on all 3 platforms (Android, iOS, Web) and made sure that all platforms use the same error codes? That was a problem with the Firebase Authentication Plugin back then.

@mamillastre
Copy link
Contributor Author

Yes I have tested on all platforms. There is no breaking changes, the message is still the same but the code is now available on a Firebase error.
I align the error codes with the web (firestore & storage) but some of them do not exist on web.
Example, on storage iOS, we have the error storage/download-size-exceededor storage/bucket-mismatchthat does not exists on Android or web.

@robingenz
Copy link
Member

@mamillastre Thanks! It is okay if an error code is not available on one platform. The error codes that do exist should just be the same across platforms. I will review it again this week so that it's part of the next release.

@robingenz robingenz merged commit ea16204 into capawesome-team:main Jan 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(storage): error codes
2 participants