-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add firestore & cloud storage error codes #789
feat: add firestore & cloud storage error codes #789
Conversation
@capacitor-firebase/analytics
@capacitor-firebase/app
@capacitor-firebase/app-check
@capacitor-firebase/authentication
@capacitor-firebase/crashlytics
@capacitor-firebase/firestore
@capacitor-firebase/functions
@capacitor-firebase/messaging
@capacitor-firebase/performance
@capacitor-firebase/remote-config
@capacitor-firebase/storage
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mamillastre Have you tested your implementation on all 3 platforms (Android, iOS, Web) and made sure that all platforms use the same error codes? That was a problem with the Firebase Authentication Plugin back then.
.../src/main/java/io/capawesome/capacitorjs/plugins/firebase/storage/FirebaseStorageHelper.java
Outdated
Show resolved
Hide resolved
Yes I have tested on all platforms. There is no breaking changes, the message is still the same but the code is now available on a Firebase error. |
@mamillastre Thanks! It is okay if an error code is not available on one platform. The error codes that do exist should just be the same across platforms. I will review it again this week so that it's part of the next release. |
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset
).Close #788