Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(performance): inconsistent handling when trace does not exist #796

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

ebarooni
Copy link
Contributor

@ebarooni ebarooni commented Jan 11, 2025

Throw error on all platforms when trace is not found.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).
  • I have read and followed the pull request guidelines.

Close #773

Throw error on all platforms when trace is not found.
@ebarooni ebarooni requested a review from robingenz January 11, 2025 19:27
Copy link

pkg-pr-new bot commented Jan 11, 2025

Open in Stackblitz

@capacitor-firebase/analytics

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/analytics@796

@capacitor-firebase/app

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/app@796

@capacitor-firebase/app-check

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/app-check@796

@capacitor-firebase/authentication

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/authentication@796

@capacitor-firebase/crashlytics

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/crashlytics@796

@capacitor-firebase/firestore

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/firestore@796

@capacitor-firebase/functions

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/functions@796

@capacitor-firebase/messaging

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/messaging@796

@capacitor-firebase/performance

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/performance@796

@capacitor-firebase/remote-config

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/remote-config@796

@capacitor-firebase/storage

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/storage@796

commit: 491fe83

Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a breaking change, please also update the corresponding BREAKING.md file.

BTW: Please always attach "Close #<ISSUE_NUMBER>" in the PR description if the PR closes an issue. 🙌

.changeset/hungry-emus-pay.md Outdated Show resolved Hide resolved
@robingenz robingenz added bug/fix Something isn't working breaking change Breaking change package: performance labels Jan 11, 2025
@robingenz robingenz added this to the v7.0.0 milestone Jan 11, 2025
@ebarooni ebarooni requested a review from robingenz January 11, 2025 21:27
Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🙌

@robingenz robingenz merged commit 73f3ca4 into main Jan 11, 2025
4 checks passed
@robingenz robingenz deleted the fix/issue-773 branch January 11, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaking change bug/fix Something isn't working package: performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(performance)!: inconsistent handling when trace does not exist on the web compared to native platforms
2 participants