Parse all kinds of declarations at function scope. #4779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These don't fully work yet, because they're not added into lexical lookup, but already mostly do the right thing. Per carbon-language#3407, disallow namespace declarations anywhere other than at file scope for now.
Also diagnose `package;`.
josh11b
reviewed
Jan 9, 2025
Comment on lines
+29
to
+33
| // CHECK:STDERR: fail_adapt.carbon:[[@LINE+4]]:3: error: `base` declaration outside class [ClassSpecificDeclOutsideClass] | ||
| // CHECK:STDERR: extend base: C; | ||
| // CHECK:STDERR: ^~~~~~~~~~~~~~~ | ||
| // CHECK:STDERR: | ||
| extend base: C; |
There was a problem hiding this comment.
Looks like there is some overlap with the testing added to toolchain/check/testdata/class/fail_base_misplaced.carbon
Comment on lines
+19
to
+23
| // CHECK:STDERR: fail_adapt.carbon:[[@LINE+4]]:3: error: `adapt` declaration outside class [ClassSpecificDeclOutsideClass] | ||
| // CHECK:STDERR: adapt C; | ||
| // CHECK:STDERR: ^~~~~~~~ | ||
| // CHECK:STDERR: | ||
| adapt C; |
There was a problem hiding this comment.
Looks like there is some overlap with the testing added to toolchain/check/testdata/class/adapter/adapt.carbon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These don't fully work in check and beyond yet, because they're not added into lexical lookup, but already mostly do the right thing.
Per #3407, disallow namespace declarations anywhere other than at file scope for now.
We don't treat statements starting with a packaging introducer keyword (
package,library,import) as declarations because they're sufficiently unlikely to occur that the error recovery doesn't seem important, and this avoids needing to disambiguatepackage.at the start of an expression.