Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve is_unique with map #81

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solve is_unique with map #81

wants to merge 3 commits into from

Conversation

quangnhat185
Copy link

@quangnhat185 quangnhat185 commented Oct 11, 2021 •
edited
Loading

A solution for this problem using map

sergio-nsk
sergio-nsk suggested changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@sergio-nsk sergio-nsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The loop is odd here. Why not like bellow?

if (character_counts[c] == 1)
  return false;

@quangnhat185
Copy link
Author

The loop is odd here. Why not like bellow?

if (character_counts[c] == 1)
  return false;

You are absolutely right, my loop is purely abundant 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-nsk sergio-nsk sergio-nsk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quangnhat185 @sergio-nsk