-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to things about packages #79
Draft
bobturneruk
wants to merge
102
commits into
carpentries-incubator:gh-pages
Choose a base branch
from
RSE-Sheffield:about-packages
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes to things about packages #79
bobturneruk
wants to merge
102
commits into
carpentries-incubator:gh-pages
from
RSE-Sheffield:about-packages
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it would be more helpful to make it clear that `environment.yml` doesn't have to always be used and the environment files can be called anything. This avoids the possibility of easily over-writing existing files. I've seen on other projects that people just go with what is in the documentation and create `sample-config.yaml`, which isn't that helpful as they should be unique to a project so people don't have 384 files all called the same thing.
Notes from an end to end run through on Windows
Testing under Linux
Closes #8 The text was already there but not visible in the last PR where the need to make this clearer was highlighted. All I've done is turn it into a Callout with a heading.
Co-authored-by: bobturneruk <[email protected]>
Removing references to installing pip in conda envs
Co-authored-by: bobturneruk <[email protected]>
Callout for excluding build variant hash
Setup-patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.