Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply contract/message card to DeployController and ConfirmTransaction #1220

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

JunichiSugiura
Copy link
Collaborator

@JunichiSugiura JunichiSugiura commented Dec 31, 2024

Note

This PR also

  • replaces legacy <Accordion />.
  • fixes tw info/warning/error color classes
Screenshot 2024-12-31 at 13 28 21

Copy link

vercel bot commented Dec 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui-next ✅ Ready (Inspect) Visit Preview Jan 7, 2025 3:07pm

Copy link
Contributor

github-actions bot commented Jan 6, 2025

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-erroralert--warning-chromium

components-erroralert--warning-chromium

components-erroralert--info-chromium

components-erroralert--info-chromium

components-erroralert--default-chromium

components-erroralert--default-chromium

components-erroralert--long-title-chromium

components-erroralert--long-title-chromium

components-confirmtransaction--default-chromium

components-confirmtransaction--default-chromium

components-controllererroralert--all-chromium

components-controllererroralert--all-chromium

components-erroralert--error-chromium

components-erroralert--error-chromium


⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

Copy link
Contributor

github-actions bot commented Jan 7, 2025

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-erroralert--warning-chromium

components-erroralert--warning-chromium

components-erroralert--info-chromium

components-erroralert--info-chromium

components-erroralert--default-chromium

components-erroralert--default-chromium

components-connect-create-createcontroller--with-theme-chromium

components-connect-create-createcontroller--with-theme-chromium

components-erroralert--long-title-chromium

components-erroralert--long-title-chromium

components-confirmtransaction--default-chromium

components-confirmtransaction--default-chromium

components-controllererroralert--all-chromium

components-controllererroralert--all-chromium

components-erroralert--error-chromium

components-erroralert--error-chromium


⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

Copy link
Contributor

github-actions bot commented Jan 7, 2025

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

🔄 Snapshot Updates in PR

The following snapshots have been updated in this PR:

components-confirmtransaction--default-chromium

components-confirmtransaction--default-chromium

components-connect-create-createcontroller--with-theme-chromium

components-connect-create-createcontroller--with-theme-chromium

components-controllererroralert--all-chromium

components-controllererroralert--all-chromium

components-erroralert--default-chromium

components-erroralert--default-chromium

components-erroralert--error-chromium

components-erroralert--error-chromium

components-erroralert--info-chromium

components-erroralert--info-chromium

components-erroralert--long-title-chromium

components-erroralert--long-title-chromium

components-erroralert--warning-chromium

components-erroralert--warning-chromium


@tarrencev tarrencev merged commit e52e690 into main Jan 7, 2025
14 checks passed
@tarrencev tarrencev deleted the chore(keychain)/sunset-legacy-accordion branch January 7, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants