Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account-sdk: include more context in the error type #389

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Jun 18, 2024

Include the contract address and method selector in the enum variant for SessionMethodNotAllowed error.

So we can get descriptive error message like this :

Not allowed to call method selector `0x2268edf67b91950354fd1020241302474ef67970e8063160d48ee70c4e0da9e` on contract `0x4c204b4778aba2dff115adfc8d89d5bdd37a0c5da1378ed36ce30242e03ff75`

@kariy kariy requested review from tarrencev and piniom June 18, 2024 20:21
Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 18, 2024 8:24pm
keychain ✅ Ready (Inspect) Visit Preview Jun 18, 2024 8:24pm
ui ✅ Ready (Inspect) Visit Preview Jun 18, 2024 8:24pm
ui-next ✅ Ready (Inspect) Visit Preview Jun 18, 2024 8:24pm

Copy link

vercel bot commented Jun 18, 2024

@kariy is attempting to deploy a commit to the cartridge Team on Vercel.

A member of the Team first needs to authorize it.

@tarrencev tarrencev merged commit 13b2c90 into cartridge-gg:main Jun 18, 2024
10 of 11 checks passed
@kariy kariy deleted the improve-signing-error branch June 18, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants