Added step for Run index in pipeline #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnkitCLI
force-pushed
the
Added-RunIndex-step
branch
from
82a963f to
5b6fb70
Compare
| @@ -94,6 +94,9 @@ public static WebElement locateRecordsInCountOnPluginNodeAsNonZero(String plugin | |||
| @FindBy(how = How.XPATH, using = "//*[contains(text(),'saved successfully.')]") | |||
| public static WebElement savedSuccessMessage; | |||
|
|
|||
| @FindBy(how = How.XPATH, using = "//*[@class='run-number' and text()='Run 2 of 2']") | |||
There was a problem hiding this comment.
It is not advisable to use text to find elements.
Please work with @GnsP to add data-cy attributes.
Curious are there 2 runs in one scenario?
|
Did step changes in the google cloud repo no need to change in e2e-tests so closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This step contains Run Index step to wait till visibility of Run 2 index on UI. This PR is related to fix for GcsCreate on cloudbuild.