Fix for Android OpenCL and added a couple of improvements #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to fix the problem exposed in this issue #7(Cannot read property 'createModel' of null) and introduces a bump on the targetApi for the manifest file (copied from the MediaPipe repo from Google)
It also adds some explanations on where to put the model files and adds the command for both cleaning and creating release APKs without the risk of keeping cached bugs from previous iterations.
I tested the results on my Oneplus Nord as well as emulated pixels and seems very legit.
Hope it helps!