fix: android inference with faster yuv->rgb conversion #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdiddy77
force-pushed
the
fix-android-convert
branch
from
2e214aa to
588f2e6
Compare
cdiddy77
force-pushed
the
fix-android-convert
branch
from
588f2e6 to
ccdf2b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android camera only produces YUV color format, whereas mediapipe only wants RGB color format.
Previously we were doing our own custom YUV -> RGB conversion, which A) was slow and B) was probably buggy.
Now we are using a faster, more correct implementation that also supports resize.
The clever resize/convert code was lifted from vision-camera-resize-plugin