Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make android object detection rectangles correct #75

Merged
merged 2 commits into from
May 12, 2024
Merged

Conversation

cdiddy77
Copy link
Owner

@cdiddy77 cdiddy77 commented May 5, 2024

There are a bunch of things tied up in here:

  • remove libyuv stuff which is no longer necessary with RNVC v4
  • change how we do inference in the frame processor, instead of using the C++ code, we have to handle the rotation ourselves -- RNVC does not do this, see here
  • RNVC also does not handle mirroring correctly -- on android. So we do it in the typescript layer, which is a little obtrusive, but works.
  • Added a bunch of tests for all of the frame to view conversion code, which, with cover/contain and mirroring, is really touchy.

result is that it works pretty well.

@cdiddy77 cdiddy77 requested a review from dwgray May 5, 2024 03:28
Copy link
Collaborator

@dwgray dwgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdiddy77 cdiddy77 merged commit 6e81951 into main May 12, 2024
2 of 5 checks passed
@cdiddy77 cdiddy77 deleted the fix-rectangles branch May 12, 2024 14:34
@cdiddy77 cdiddy77 mentioned this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants